This diff should fix AJAX windows of Twinkle for Safari 3.0 I'll do more tests in the coming days to see if there are other problems. --TheDJ (talk • contribs) 19:33, 29 June 2007 (UTC)

 Fixed _→AzaToth 19:41, 29 June 2007 (UTC)

And one more: diff this fixes the rollback/vandalism links in contrib lists. And thank you for applying the previous fix that quickly. --TheDJ (talk • contribs) 20:30, 29 June 2007 (UTC)

Hmm, that's a strange fix, perhaps it's better to check for Array.hasProperty() instead. _→AzaToth 20:56, 29 June 2007 (UTC)

Oh, I mean Array.hasOwnProperty() _→AzaToth 21:04, 29 June 2007 (UTC)

To quote #webkit

someone> thedj: stop using "for(var i in list)" -- you're getting some weird indexes (like "length").... this is a case when you really should use the traditional "for(var i=0; i<list.length; i++)" construct me> ah, i'll try that. someone_else> thedj: "for (var i in list)" will iterate over the properties of list, not the items or indices of the Array

I'm now trying to find a problem with the actual "rollback". In revertCallback3() document.getElementById('globalWrapper').appendChild( form ); gives me a WRONG_DOCUMENT_ERR: DOM Exception 4. and then fails. I'm not sure yet why. --TheDJ (talk • contribs) 21:09, 29 June 2007 (UTC)

revertToRevision() does seem to work... i'll see if I can determine what the big difference is there. --TheDJ (talk • contribs) 21:34, 29 June 2007 (UTC)

twinklefluff still uses some old code (have really never updated that part recently), you are right I should use for(;;) instead of for(in) for Arrays (has been a bad habit, for(in) is really only for Object objects). Now that tweinklexfd is cleaned up, I could take a look to see what could be done in the fluffy file. _→AzaToth 21:50, 29 June 2007 (UTC)

Another one of these for loops: diff Judging from some of the erratic results I see, this might be a common problem in the twinkle code :D --TheDJ (talk • contribs) 22:25, 29 June 2007 (UTC)

2 more in xfd, one more in fluff And morebits contains so many for loops, i probably better leave those to you :D --TheDJ (talk • contribs) 22:34, 29 June 2007 (UTC)

I just noticed that you missed the important part of the morebits.js Safari fix. It is actually the dummy stylesheet.appendChild(document.createTextNode()); lines that were of the greatest importance. There is a bug currently with adding "empty" style nodes via DHTML. It has been reported and should be fixed in later update of Safari 3 beta's. --TheDJ (talk • contribs) 00:22, 30 June 2007 (UTC)

Hehe, that's not much I can do anything about, mostly because I can't find that line :) _→AzaToth 00:31, 30 June 2007 (UTC)

I'll try to show again. diff this is the important part in fixing simplewindow and quickform. --TheDJ (talk • contribs) 11:42, 30 June 2007 (UTC)

Works perfectly now. thanks man. !! --TheDJ (talk • contribs) 16:32, 1 July 2007 (UTC)

I chose "last" when in the history and got a link like this: [1] that certainly cannot be good. No idea where it is coming from though. Under investigation. --TheDJ (talk • contribs) 16:32, 1 July 2007 (UTC)

And getting back to this issue: "In revertCallback3() document.getElementById('globalWrapper').appendChild( form ); gives me a WRONG_DOCUMENT_ERR: DOM Exception 4. and then fails" reported above... Apparently this is indeed an illegal operation, and the mozilla docs indicate that Firefox 3.0 will enforce the same. Apparently the way to solve it is something like this:

        var importedform = document.importNode( form, true );
	document.getElementById('globalWrapper').appendChild( importedform );

	Status.status( 'Submitting the form...' );
	importedform.submit();

It did not work in FF 2.0.0.4, so either i did not understand what this revertCallback3 is to do, or this is gonna be considerably difficult to support both in FF2 and FF3 --TheDJ (talk • contribs) 17:20, 1 July 2007 (UTC)

Ah, yea... _→AzaToth 17:50, 1 July 2007 (UTC)

How do you make this work? Not all the tabs are appearing, and yes, I bypassed the cache. And, now the interface is not looking like anything shown on the instruction page. It really needs a manual or something. Aditya Kabir 10:34, 1 July 2007 (UTC)

Can you please report what browser version and what Operating System you are using ? (As a side note, in testing Safari 3.0 I have noticed a sort of randomness in the presence of the tabs as well. It seems to vary per refresh. I have some ideas indicating it may be related to pageload speeds. --TheDJ (talk • contribs) 15:18, 1 July 2007 (UTC)

I like to keep my watch list limited to articles I care about. Generally if I revert some vandalism I'm not too worried about that article in a few days. As such I'd like to keep TW from adding those pages to my watchlist. I tried using TwinkleConfig = { userTalkPageMode : 'tab', openTalkPage : [], watchSpeedPages : [], watchProdPages : false, watchRevertedPagess : [], watchWarnings : [] }; importScript('User:AzaToth/twinkle.js'); and made sure to refresh but it is still adding reverted pages to my watch list. Anyone know what I need to change? Thanks. Mikemill 20:25, 1 July 2007 (UTC)

You have to change Warnings to false, not leave it empty. As for SpeedPages and and RevertedPages (which has a typo, an extra s), you will need to leave those empty. Cheers, Anas ^talk? 20:36, 1 July 2007 (UTC)

A few days ago, when looking at the diff between changes pages, the colouring just disappeared. Is this anything to do with TWINKLE, or is it happening across the board with everyone on wikipedia? -007bond aka Matthew G aka codingmasters 01:11, 2 July 2007 (UTC)

in morebits.js around line 119:

for(i in this){if(i!=="toSource")

that should probably be

for(i in this){if(i!="toSource")

or at least, I have never seen !== used before... --TheDJ (talk • contribs) 23:18, 1 July 2007 (UTC)

Someone just messaged me that it's a strict check for the type... You learn something new every day I guess. --TheDJ (talk • contribs) 23:23, 1 July 2007 (UTC)

BINGO. i found the source of my issue with this random toSource in my "last" link. this was causing it. See also the explanation here. --TheDJ (talk • contribs) 01:54, 2 July 2007 (UTC)

http://www.devpro.it/JSL/ _→AzaToth 13:08, 2 July 2007 (UTC)

Ah. so either you need to do: for(var key in myObject) { if(!$JSL.has(key)) { in every for loop, or do delete Object.prototype.toSource; right after opening JSL --TheDJ (talk • contribs) 13:52, 2 July 2007 (UTC)

True, but I could just remove it, it's not like I'll be using toSource() in production directly :). Sadly it's only Gecko that has a logical way to handle prototypes for Objects and Arrays :( _→AzaToth 14:06, 2 July 2007 (UTC)

is there somewhere a complete list of messages (and text) twinkle leaves? i would be great to have it as a reference...particularly since tw no longer defaults to preview before saving....or does it? --emerson7 | Talk 13:26, 2 July 2007 (UTC)

If you think about the warn module, see WP:UWT. _→AzaToth 13:50, 2 July 2007 (UTC)

I was a bit surprised that this edit was marked as minor. In my settings (User:Pekaje/monobook.js), I have markProdPagesAsMinor set to false. Anyway, this states that prod should not be marked minor, so I'm surprised the setting is even there. --Pekaje 20:08, 2 July 2007 (UTC)

I don't know whether it would be easy to do, but perhaps use of Twinkle for non-vandalism reverts could be disabled, or made more difficult. Edits like these [2], [3] are unhelpful because there is no attempt at communication. --Tony Sidaway 13:56, 1 July 2007 (UTC)

First of all, restricting TWINKLE to vandalism only would be a bad idea, since it comes in handy in many other ways. That said, we presently have text boxes for edit summaries for good-faith and restoring back to a specific version. Are you recommending that we add a summary box for the "neutral" rollback? SchuminWeb (Talk) 14:00, 1 July 2007 (UTC)

The problem in my humble opinion (aside from the aspect that I don't see a way to accurately identify vandalism) is that there's little to be gained. The same rollback could have easily been done manually. It's really just a couple of extra clicks. -- S ^up? 14:03, 1 July 2007 (UTC)

That should certainly be the case (and in my opinion unless one is provided the rollback should not be done). It would make editors have to think and justify their action for all to see and understand. → AA ^{(talk • contribs)} — 14:12, 1 July 2007 (UTC)

Well, I'd just like to see whatever rollback function is provided here used with some responsibility. When rollback was an admin-only feature, its use for non-vandalism reverts was frowned upon. Now that anybody can do it I fear that editors are finding themselves seduced by the ease of the one-button-revert, and some of them no longer feel that they have to justify their actions properly. --Tony Sidaway 14:22, 1 July 2007 (UTC)

I campaigned awhile ago to get edit summaries added to the revert functions for this exact reason. It's now an optional feature with the AGF rollbacks. Tony is right here. Using these automated summaries for non-vandalism reversions follows the letter of the rules, but it subverts their spirit. When you're reverting edits that somebody put some effort into the least you can do is give that editor the courtesy of an explanation. But the problem, really, is editors and not TWINKLE. Because TWINKLE now offers that functionality to explain yourself and some editors are just too lazy to use it. --JayHenry 15:14, 1 July 2007 (UTC)

Totally agree. Perhaps it's time to force use of an appropriate edit summary onto people, at least by default. --TheDJ (talk • contribs) 15:15, 1 July 2007 (UTC)

Yeah, this is definitely more of a "people" issue than a technology issue. By the way, has anyone spoken with the user in question at the top of this thread? It seems that more could be gained by discussion with the involved parties than modifying TWINKLE. SchuminWeb (Talk) 15:31, 1 July 2007 (UTC)

I saw the user in question leave a few notes on some user's pages about leaving and they now have a wikibreak notice that they won't be around until September. --After Midnight ⁰⁰⁰¹ 15:39, 1 July 2007 (UTC)

The user in the diffs has now been blocked for 3RR, probably using TW all times. The only thing I can think of is a simple access list where any user that seems responsible can be added to the list by an admin. But then we would need AzaToth to put in something to check to page (but if it checked every time you tried to do something with TW, it would slow everything down). We just need people to be more responsible. --(Review Me) R ^{you talking to me?}Contribs_@ (Let's Go Yankees!) 16:29, 1 July 2007 (UTC)

Access lists are a bad idea for TWINKLE. That would take much of the usefulness (speed) right out of it. Don't punish the legitimate users because of a few baddies. SchuminWeb (Talk) 17:47, 1 July 2007 (UTC)

Interpreted JavaScript is not that slow, I don't think. (Recall the huge list of regexen that Lupin's tool has to go through.) Really, the best way to increase the speed for this script would be to cut down MediaWiki:Edittools, since the DOM for all of that has to load every time an edit is made. Or edit tokens from the API, if that were possible. Gracenotes^T § 21:02, 1 July 2007 (UTC)

EditPage.php must be totally rewritten before the API can handle edits :( _→AzaToth 21:50, 1 July 2007 (UTC)

Or something can be hacked together wherein the API reads the HTML interface, but I seriously doubt that would be... elegant. Gracenotes^T § 22:13, 1 July 2007 (UTC)

I did approach this editor on the issue about six weeks ago[4], and he seemed to acknowledge that he needed to improve [5] but obviously he must have backslid. At that time he was using popups so obviously it's as much a human issue as it is one of technology. --Tony Sidaway 16:37, 1 July 2007 (UTC)

Have added a new configuration parameter now (offerReasonOnNormalRevert), that if true (default) will offer a prompt for edit summary on normal reverts. _→AzaToth 16:42, 3 July 2007 (UTC)

Thanks! Does the monobook need to be refreshed to make use of this new feature? → AA ^{(talk • contribs)} — 16:55, 3 July 2007 (UTC)

and refreshing the cache breaks my .js page. Any ideas? Smokizzy (talk) 15:58, 2 July 2007 (UTC)

It (twinkle) is just not working (in Opera). Smokizzy (talk) 21:33, 3 July 2007 (UTC)

diff Not very clean, i'm sure you want to fixup this file more extensively, but this will do it for me atm :D --TheDJ (talk • contribs) 20:11, 3 July 2007 (UTC)

Hi, i noticed that the warning tabs are now in a signal tab. I found that using this slows me down when reverting vandalism. Could i have the older version of the warning system. Thank you, -- (Cocoaguy ここがいい _contribs^talk) 21:31, 4 July 2007 (UTC)

Someone split off a version of the old twinklewarn here User:Koder/twinkle-oldwarn.js, though I don't know how well-maintained it is. I think it still uses level 3 headers, which was inappropriate. You could of course split it off into your own version and fix that. I would say that I also prefer the old style tabs. Fewer clicks, easier to find the appropriate warning, and the possibility of a preview before submitting. So OK, there were quite a few tabs to clutter up the place, but it wasn't that bad. --Pekaje 22:40, 4 July 2007 (UTC)

To who ever made it the five tab system again, Thanks -- (Cocoaguy ここがいい _contribs^talk) 00:23, 6 July 2007 (UTC)

Remember, as that one isn't updated with the templates, if it was to be updated, it would be 7-8 tabs. _→AzaToth 00:48, 6 July 2007 (UTC)

TWINKLE has been hanging up a bit lately when doing reverts, regardless of whether it's AGF, normal, vandal, or restoring to a specific edit. It hangs on "Updating the summary..." and has been doing this both on my home PC and my office Mac, both of which run Firefox. Any thoughts? SchuminWeb (Talk) 19:07, 5 July 2007 (UTC)

When it happens again, try taking a look at Tools->Error Console and see if there is a relevant warning or error message. --TheDJ (talk • contribs) 22:53, 5 July 2007 (UTC)

Here's what it produced:

Error: TwinkleConfig.watchRevertedPages.indexOf is not a function

Source File: http://en.wikipedia.org/w/index.php?title=User%3AAzaToth%2Ftwinklefluff.js&action=raw&ctype=text/javascript Line: 650

Any ideas? SchuminWeb (Talk) 23:18, 5 July 2007 (UTC)

Rogue space character.

'wpWatchthis': TwinkleConfig. watchRevertedPages.indexOf( 'torev' )

Should be quickly fixed when AzaToth reads this. --TheDJ (talk • contribs) 23:44, 5 July 2007 (UTC)

The other problem location is the same error on line 540. --TheDJ (talk • contribs) 23:47, 5 July 2007 (UTC)

Hi. I'm having trouble with the ARV scripts in my userspace (aiv, uaa) since I installed Twinkle - it isn't the scripts, as apart from a minor change in the AIV script to toolbox it and some reference changes in the UAA script, they are exactly the same as ARV. The reports just seem to hang on "Searching for existing report..." Will ^(talk) 21:29, 6 July 2007 (UTC)

Even though TwinkleARV was based on LightDarkness' script in the beginning, there are no common code left. _→AzaToth 21:34, 6 July 2007 (UTC)

Does morebits or the reversion script (the only twinkle scripts I'm using) clash, though? Will ^(talk) 21:45, 6 July 2007 (UTC)

It's definitely Twinkle, though - when I removed it, ARV was working fine. Will ^(talk) 22:15, 6 July 2007 (UTC)

It could be that you are using for var i in for arrays. _→AzaToth 19:38, 8 July 2007 (UTC)

Hi, for some reason twinkle is not working on my account. -- (Cocoaguy ここがいい _contribs^talk) 19:17, 8 July 2007 (UTC)

More information is needed to be able so solve this problem. _→AzaToth 19:40, 8 July 2007 (UTC)

Actually all of my monobook scripts are not working -- (Cocoaguy ここがいい _contribs^talk) 19:46, 8 July 2007 (UTC)

Try clearing out your monobook, clearing your cache and then re-adding them one-by-one, refreshing each time. you should find a conflict or error in this manner. --After Midnight ⁰⁰⁰¹ 20:14, 8 July 2007 (UTC)

Thanks -- (Cocoaguy ここがいい _contribs^talk) 23:13, 8 July 2007 (UTC)

Nice one, this should make it a lot easier to work through the gigantic backlog of fair-use images with missing sources and/or missing rationales. I think one more tag needs to be added, though. When a fair-use image has been rescaled to qualify for fair use, the older high-res versions should be deleted from the history. Simply substing the {{furd}} template is enough, so it should be easy to add. --Pekaje 21:41, 8 July 2007 (UTC)

Also, {{Non-free reduce}} would be nice, though it doesn't quite fit with the spirit of the dialog. --Pekaje 21:49, 8 July 2007 (UTC)

It also occurs to me that I spoke too soon about it {{furd}} being easy to add, since to be a good implementation it also needs to remove {{Non-free reduce}} and all the other variants ({{FairUseReduce}}, {{Fairusereduce}}, {{Fair Use Reduce}}, {{Fair use reduce}}, and {{Reduce size}}). At times like this I wish I knew enough JS to implement this myself, so I wouldn't have to ask for these things ... :-) --Pekaje 22:28, 8 July 2007 (UTC)

Have made {{di-replaced fair use}} as a thought how I feel it should be handled (the older template did had some strange things). _→AzaToth 23:25, 8 July 2007 (UTC)

I've been doing some testing of the whole suit in lastest Safari 3.0.2 beta. So far:

• Revert I couldn't get to work (any of the 3)
• Warnings are all working well
• ARV is broken (the thing comes up, and the pop-down menu is there, but there's no box for comments or a submit button)
• CSD works finally (it didn't in 2.0)
• CSD images also works
• diff tabs are working
• Protections are working (although it would be nice for there to be a custom field for time because I like to use odd times like 18 days or 10 days and the like)
• The prod comes up (I haven't actually press submit yet, but I assume that if it comes up it will work)
• xfd is variable working
• salting works

Now I know that Safari is not the main development platform, I just thought I'd give some feedback on how things are working here (and I assume that at least some of this applies to Konqueror now or will soon since webkit comes from khtml). -Royalguard11(T·R!) 05:47, 10 July 2007 (UTC)

I have a fork here: User:TheDJ/twinkle.js that should work with reverts. I spent some time over the past two weeks to investigate Safari 3 issues so I could hand solutions to AzaToth, saving him some time. The reverts are on the TODO list, but my version has a "workaround" for that. It's good to hear that salt and protections are working. I'll see if I can further test ARV to see what is wrong there. It is good to see that with Safari 3.02 we have come so close to Firefox in CSS and JS capabilities that it just took a few changes to Twinkle to get it to work. --TheDJ (talk • contribs) 13:49, 10 July 2007 (UTC)

I will be sort of away the next week, (visiting my father), off course i can do edits, but I don't have usual work bench I'm using, and the possibillity to test on my test wiki. twinklefluff.js requires probably lots of changes, as I havn't touched that code in a long time. Also, could you check that twinlkeimage.js works in safari? it's a newcommer. _→AzaToth 14:16, 10 July 2007 (UTC)

I have tracked the ARV issue. It's due to getChecked() on line 40 of twinklearv.js

if( !( nodelist instanceof NodeList ) ) {

This is bug in Safari 3.0.2 that I have reported here. It might have recently been fixed in a Safari nightly, but that is still under investigation. I will also check out twinkleimage.js a bit more though it seems to work. --TheDJ (talk • contribs) 14:53, 10 July 2007 (UTC)

I cannot find a problem in twinkleimage.js Seems to work just fine. I'm remove the instanceof check in arv in my "safari compatible" version for now, but it's not something i think should go into the main Twinkle. Especially with this most likely already fixed. --TheDJ (talk • contribs) 15:12, 10 July 2007 (UTC)

Wow, I didn't know that there were people working on Safari issues (and I was using Camino before 3b came out because it worked better with these scripts). I'm only actually using warnings, speedy, diff, protect, prod, xfd and salt in my monobook.js. The salt was actually working with Safari 2 I believe, but all the ones with the weird in-window popups (speedy was the only one I tried in 2 and it didn't work) have just started working with 3b. I don't really need the reverting stuff (I use popups for reverting still, which also work better in 3b), I just thought I'd check them out for other Safari users. -Royalguard11(T·R!) 16:29, 10 July 2007 (UTC)

FYI. "revert to this revision" (added to the left of the diff view) does work. And if you have any other issues, please do report them here or to me personally. I don't mind tracking the issues down. --TheDJ (talk • contribs) 18:34, 10 July 2007 (UTC)

The block templates "Block level 1", 2 and 3 all have a minor, yet very important error. Whenever I use these templates, a "{{{reason}}}" is there. There should be an option for the reason for blocking. My suggestion is that you add this option, and if it is left blank, a reason like "abusing editing privileges", or something of this sort, be automatically added. Thanks, Anas ^talk? 21:03, 11 July 2007 (UTC)

Is that what the "More" box is for, or are you looking for something slightly different. --After Midnight ⁰⁰⁰¹ 00:52, 12 July 2007 (UTC)

Woops! I must've thought it was additional commentary. My bad. Still, can a standard reason be applied when you enter no reason? —Anas ^talk? 01:06, 12 July 2007 (UTC)

Is there a way to add "[rollback (AGF)] || [rollback] || [rollback (VANDAL)]" when you click older edit. I have come to a couple of vandalized pages that has more than one vandalized edit by more than one user. Is this possible?PGPirate 20:06, 9 July 2007 (UTC)

The idea of the rollback function is that if the most recent user makes a bad edit, you can roll back all their edits at once. If it's more, the "restore this version" (or however it's worded) link comes into play. You go back into the history and pick a revision to restore to. You roll back more than one user's edits with a rollback function, and it gets problematic. SchuminWeb (Talk) 23:03, 9 July 2007 (UTC)

I understand this isn't exactly in line with the previous comment, but could you tell me what AGF stands for?(Also, is there a manual around? Most things are self explanatory, but I kind of wonder if I'm missing anything just because I'm not looking for it)Camann•TALK 17:22, 12 July 2007 (UTC)

AGF = Assume Good Faith. Goes with WP:AGF. SchuminWeb (Talk) 19:24, 12 July 2007 (UTC)

Ah, much thanks.Camann•TALK 19:45, 12 July 2007 (UTC)

I know there are supposedly problems with Firefox due to development at the moment, but I would like to check this anyway. It seems CSD is broken for me. I click the button, click the criteria, and it then says "Fetching page" (or words to that effect), then shortly after "Deleting page..." and then nothing happens. Any ideas? —Sean Whitton / 13:43, 12 July 2007 (UTC)

problem limited to sysop speedy functionality. Somewhere between "deleting page..." and "Page/Image deleted, remember to wait until it\'s all done.". sean was using FF 2.0.0.4 and reported he had no warnings/errors in his JS console. --TheDJ (talk • contribs) 15:14, 12 July 2007 (UTC)

What would be useful is for there to be a guide to Twinkle in how to use it. I couldn't spot one so maybe one needs to be written. I'd be happy to help on this, although for some of the more advanced and administrator only I'd need some assistance from someone with the required rights. --Mendors 22:29, 12 July 2007 (UTC)

Just wondering if support of this template could be added to twinklewarn. Thanks, Giggy _U^CP 00:11, 13 July 2007 (UTC)

Take a look at Wikipedia:Miscellany_for_deletion#2007-07-13_2 for all the "User:User:Foo" pages that that were auto-created when I attempted to report several IPs to WP:SSP using Twinkle. I now realize that it was unnecessary to include the 'User:' prefix in the TW interface when compiling the list of socks - but I had no way of knowing this until bad things happened... --Kurt Shaped Box 01:53, 13 July 2007 (UTC)

Could be fixed. _→AzaToth 10:43, 13 July 2007 (UTC)

After I installed Twinkle in my monobook, I proceeded to clear my cache. WHen I attempted to revert vandalism using any of the three options given, I was given the following error message: "Grabbing edit form............................................... Updating the textbox... couldn't grab element "editform", aborting, this could indicate failed respons from the server" I'm wondering why this is happening? I'm using Firefox 2, and cleared my cache twice. Elenseel 06:34, 13 July 2007 (UTC)

If you are using windows, it can be because you are using one of the firewalls specified on the main page. _→AzaToth 10:45, 13 July 2007 (UTC)

I noticed a bug in Twinkle. When I put a page up for AfD, for some reason the "This article's entry" link in the AfD tag stays a redlink even after the actual discussion page is made. The only way I can fix this is by tweaking the AfD tag itself. Ten Pound Hammer • ^{(((Broken clamshells • Otter chirps)))} 17:11, 13 July 2007 (UTC)

Have you tried purging the page? I often see this happen, because the caching software renders the page while the discussion page hasn't been created yet. Back in April I suggested the addition of a page purge at the end, but it doesn't look like it's been done. I think it will appear on its own in a few minutes, otherwise. --Pekaje 18:45, 13 July 2007 (UTC)

I just got a heads up by another editor about this edit. Definitly a bug in the image removal system which by the way is great. Rettetast 17:59, 11 July 2007 (UTC)

Can you please report what browser, OS and what versions you were using? AzaToth isn't around much this week, but i'll see if I can determine the seriousness of this problem. --TheDJ (talk • contribs) 18:16, 11 July 2007 (UTC)

The % seems to indicate that this is a case where the status counter has become confused about which object/document it's editing. However it's too deep for me to figure out where the problem is exactly. Having the browser info will still be very helpful, it might be that only some browsers have this problem. --TheDJ (talk • contribs) 18:38, 11 July 2007 (UTC)

Firefox 2.0 and XP. May the problem be that I delete different images in different tabs to quickly? Rettetast 20:43, 11 July 2007 (UTC)

Could you try to reproduce the error? (like undelete the image and temporary reset all the linked pages to that instance). _→AzaToth 16:05, 12 July 2007 (UTC)

Now it worked like it should. Rettetast 19:58, 13 July 2007 (UTC)

Then it's probably more of a hiccup problem. _→AzaToth 09:07, 14 July 2007 (UTC)

Where did the name Twinkle come from? Just curious and couldn't find the origin anywhere. --JayHenry 03:52, 12 July 2007 (UTC)

It's an abbrevation of Twinklefluff. _→AzaToth 15:59, 12 July 2007 (UTC)

Well, okay, where did Twinklefluff come from? And don't say from Twinklewarn!! --JayHenry 16:36, 12 July 2007 (UTC)

Twinklefluff came from a random name generator. _→AzaToth 16:04, 14 July 2007 (UTC)

Do you have a link to said random name generator? (Could be fun) SchuminWeb (Talk) 17:48, 14 July 2007 (UTC)

When Tinkle adds this tag, if the image doesn't have a frame or thumb option the caption seems to be invisible, which make the tag much less helpful. I ran a script last night to add the thumb option to any of these images that didn't already have thumb or frame. Is it possible for Twinkle to add the thumb option on its own? — Carl (CBM · talk) 14:39, 14 July 2007 (UTC)

I've tried this on several computers, several OS's, and several browsers. Nothing is ever working. I always get this error: QueryString not defined, line 110, twinklefluff.js and missing . after operator: QueryString.static: line 1169, morebits.js. I have no idea why you claim it's working on any other operating systems; I can't see why it's not working on any of mine, but apparently no one else is complaining about it? The Evil Spartan 19:37, 7 July 2007 (UTC)

Try removing recent2.js first, I'd recommend. TW does clash with other scripts (ARV, AutoAFD, etc) Will ^(talk) 19:51, 7 July 2007 (UTC)

Still no go, even after removing other stuff. I've really tried this on a lot of combinations. I'm really starting to wonder if there aren't a lot of other people who couldn't get it to work, and I just don't know about it. It's not like I'm inept with this stuff (I'm a programmer). The Evil Spartan 19:55, 7 July 2007 (UTC)

Last try, script still didn't work. I'm currently on FF 1.0.7 on a Linux box. The Evil Spartan 19:57, 7 July 2007 (UTC)

I'm not really an expert in this field, so excuse me if this sounds irrelevant, but why not try a newer version of Firefox? —Anas ^talk? 20:09, 7 July 2007 (UTC)

Yeah, it stopped working on that version some months back. I know this because it used to work at my University, but then one day it didn't, and they use a Firefox of roughly that generation. Time to upgrade (or go kick an admin, as it were in my case). --Pekaje 22:53, 7 July 2007 (UTC)

Well, I have the serious problem of using Firefox at the library :). It's the only place I can usually use a computer. So it's hard to install a more recent version. But, in any case, I've used lots of OS's, and lots of browsers (FF on Linux, Windows, Mac).

In any case, I'm now using IE 7.0 on Vista, and I'm getting the same message: the one about QueryString on line 111. This has me almost suspcious: I have no idea how you guys get this to work on; I've used so many OS's and browsers: I've even created other usernames to try this on, and it didn't work. What the heck is going on? The Evil Spartan 21:26, 8 July 2007 (UTC)

It doesn't work on IE. Try Firefox; it should work. I use Firefox 2.0.0.4 and Vista and it's working perfectly. —Anas ^talk? 23:30, 8 July 2007 (UTC)

OK, I finally got it to work on a computer. I had to manually add a script to my js file saying "only load on FF 2 or greater!". Maybe you could do the same. The Evil Spartan 22:26, 21 July 2007 (UTC)

The notification to the user for a IFD makes a double sig.[6] Probably a script error, but it needs to be fixed. --Dark Falls ^talk 08:09, 19 July 2007 (UTC)

It's because {{idw}} and {{idw-pui}} already transclude the sig. The fix in twinklexfd.js is to change text += "\n\{\{subst:idw|1=" + wgPageName + "\}\} \~\~\~\~"; to text += "\n\{\{subst:idw|1=" + wgPageName + "\}\}"; and text += "\n\{\{subst:idw-pui|1=" + wgPageName + "\}\} \~\~\~\~"; to text += "\n\{\{subst:idw-pui|1=" + wgPageName + "\}\}";. east.718 07:25, 23 July 2007 (UTC)

Probably a small fix to do, but "speedied deleted" is just awful grammatically. Would be better phrased as "speedily deleted", or "speedy-deleted". The former ("speedily deleted") would probably be the best one, though I consider there to also be a valid reason to choose "speedy-deleted". But "speedied deleted" needs to go. SchuminWeb (Talk) 22:04, 20 July 2007 (UTC)

As nitpicky as it sounds, but yeah, a fix would be nice. :-) —Anas ^talk? 23:01, 20 July 2007 (UTC)

Hey, don't complain about my superior grammar! _→AzaToth 10:04, 23 July 2007 (UTC)  Fixed

I posted this feature request in the list above:

• Allow changing warning level without resetting the warning type to "Vandalism"

AzaToth responded:

Dont know how to fix that, as not all levels has the same warnings. _→AzaToth

I meant that it would just do this for templates that have both warning levels. For example, if you selected the warning about NPOV, and then selected Level 2, it would remain on NPOV. If you selected the Assume Good Faith template on Level 1, then selected Level 4, it would reset to Vandalism, as there is no {{Uw-agf4}}. Hope that clears things up. Insanity Incarnate 15:52, 21 July 2007 (UTC)

The problem is that at the moment, they are not defined as "levels" but only as "categories", each have a specific key, for example uw-test2 etc... It could be fixed, but it might require extensive work. _→AzaToth 18:01, 23 July 2007 (UTC)

Ok, not so difficult; added the template name in the list also as prefixing the label.  Fixed _→AzaToth 18:21, 23 July 2007 (UTC)

Just to notify that the spam level 2 warning turns out to give a message for the vandalism level 2. — Indon (reply) — 10:20, 23 July 2007 (UTC)

That's theoretically impossible. _→AzaToth 10:25, 23 July 2007 (UTC)

Unable to replicate. Works fine for me. ffm 17:49, 23 July 2007 (UTC)

I added the importScript('User:AzaToth/twinkle.js'); to my monobook.js and i refreshed my browser bypassing the cache, however nothing changed. Is there a page on wikipedia I need to go to, to use TWINKLE? because in the screen shot, it shows the boxes come up next to "Article" "Discussion" "Edit this page" "history" on that section. What do I do? Im using Firefox 1.0.3 by the way. GBenemy 02:05, 24 July 2007 (UTC)

Is there any reason you're using Firefox 1.0.3? If it's a work issue or something, try bugging your sysadmin to upgrade. east.718 02:24, 24 July 2007 (UTC)

HAHA I don't work, I'm 16. I'm using it because as far as I knew it was the latest version. I'm assuming from your response WINKLE doesn't work with this version of FireFox then? GBenemy 02:27, 24 July 2007 (UTC)

I don't think it's worked on a version that old for a while. Upgrade to 2.0.0.5 and see what you get. east.718 02:33, 24 July 2007 (UTC)

Unless you know a way to download and install applications on a limited account on Windows XP (bypassing the Admin account) I doubt that will be possible (Parent's computer..."YOU'VE GOT TOO MANY BLOODY PROGRAMS ON OUR COMPUTER ALREADY BLAH BLAH" - you get the idea). The version of firefox I have was only downloaded about 7 months ago, and I wasn't aware of any recent updates. If there's any other way I can get TWINKLE to work, please help me. GBenemy 02:38, 24 July 2007 (UTC)

Try this. east.718 03:06, 24 July 2007 (UTC)

THANK YOU SO MUCH. Now I have the latest version of Firefox, and my parent don't know I've installed it MWAHAHAHA thanks alot, (oh and yes, TWINKLE works with this version)...thanks alot east. GBenemy ^(talk) 04:19, 24 July 2007 (UTC)

I added importScript('User:AzaToth/twinkle.js'); into my monobook or w/e

now what? MMAfan2007 18:42, 5 July 2007 (UTC)

Purge your browser's cache (hit Control-Shift-R in Firefox or Control-F5 in Internet Explorer), as indicated in the project page. —Anas ^talk? 18:45, 5 July 2007 (UTC)

Ok, it just refreshed IE MMAfan2007 18:56, 5 July 2007 (UTC)

You've installed it incorrectly. Replace the contents of your monobook.js with this: importScript('User:AzaToth/twinkle.js'); east.718 03:35, 10 July 2007 (UTC)

Thanks, I did what you said. Alright so what exactly will happen now? I got confused in the project page as to what twinkle does or will do for me. MMAfan2007 20:06, 10 July 2007 (UTC)

Before I answer, do you use Internet Explorer? Twinkle does not work in IE and likely never will. east.718 20:10, 10 July 2007 (UTC)

No, I use AOL. MMAfan2007 20:59, 11 July 2007 (UTC)

That uses MSHTML (or whatever it's called) as its rendering engine; Twinkle won't be working for you. Sorry. east.718 23:27, 12 July 2007 (UTC)

Tell Wiki to make it work. MMAfan2007 20:23, 16 July 2007 (UTC)

Tell what? _→AzaToth 21:07, 16 July 2007 (UTC)

TW is not by Wikimedia, AzaToth maintains it on a strictly volunteer basis. east.718 23:15, 16 July 2007 (UTC)

Great, tell him to make it work. MMAfan2007 21:58, 24 July 2007 (UTC)

Twinkle stopped working completely. I have been playing around with my monobook.js file in the last few days. I also tried pop-ups, but I removed it cause I didn't like it. How do I fix this? -Flubeca^Talk 22:24, 23 July 2007 (UTC)

Try this for your monobook.js and this for your monobook.css. east.718 02:33, 24 July 2007 (UTC)

Nope, still nothing, however my tabs are "bubbley" again. -Flubeca^Talk 14:28, 24 July 2007 (UTC)

Hi, in going through a category when tagging for no rationales etc TWINKLE placed a large number of tags on a user's talk page (who got fed up). Subsquently and following some advice on IRC, I reformatted and collapsed the messages on the current revison: [7]

It would be appreciated if you could consider some kind of less verbose output for TWINKLE in respect of mass tag runs:) Sfan00 IMG 10:16, 26 July 2007 (UTC)

It's not up to teinkle, but what's defined in the di- templates. _→AzaToth 12:52, 26 July 2007 (UTC)

Hi, would it be possible for someone to get hold of a list of ALL mainspace articles TWINKLE's tagged image captions in? The reason is so that the glitch mentioned elsewhere on this page can be checked for and fixed if needed. Sfan00 IMG 18:30, 29 July 2007 (UTC)

• Category:Articles that include images for deletion --After Midnight ⁰⁰⁰¹ 18:47, 29 July 2007 (UTC)

Thanks, OK Once I've finished checking my own contribs I'll make a start on those :) — Preceding unsigned comment added by Sfan00 IMG (talk • contribs) 18:49, 29 July 2007

When I speedied a page to complete a history merge (G6), TWINKLE removed all the links to the page from other articles, which had to be restored later. For history merge deletions, can this step be taken out, since the page is getting restored in the end? SchuminWeb (Talk) 20:40, 29 July 2007 (UTC)

It would be nice to have {{db-empty}} in the list of speedy templates, as it provides better rationale for completely empty articles than just {{db-nocontext}} or {{db-nocontent}} --Closedmouth 06:14, 30 July 2007 (UTC)

Hi, apparently when using Twinkle to tag images for no rationale, it screws up image sizing on some article pages.

I had someone give me a warning about it. See [8] and [9]

Much appreciated if this minor glitch was remedied soon :) ShakespeareFan00 23:21, 14 July 2007 (UTC)

Actually, I am going through and changing some of them to make the caption visible, even at the cost of making the page very ugly. It seems there isn't any automated way to keep the pages beautiful and also add captions. — Carl (CBM · talk) 00:12, 15 July 2007 (UTC)

I noticed that bug too, the other day. It seems that this might be a general problem for images without captions, but with resizing. A solution that doesn't screw up the pages in question is to look for ###px and if it's the last thing, add a | before the deletion caption. However, in infoboxes this makes the text barely visible (only on hover), and the tag should actually go in the caption entry. Not an easy thing to fix in software, so I think it's worth manually verifying all these tags (since TW also sometimes "forgets" to do a step or two or three in the procedure). --Pekaje 07:06, 16 July 2007 (UTC)

I knew there would be some problems with the current algorithm, but I didn't know how to fix it, the relevant code is in morebits.js in the Mediawiki.Page prototype (especially the line after the comment "just put it at the end?"):

	addToImageComment: function( image, data ) {
		var first_char = image.substr( 0, 1 );
		var image_re_string = "[Ii]mage:\\s*[" + first_char.toUpperCase() + first_char.toLowerCase() + ']' +  RegExp.escape( image.substr( 1 ), true ); 
		var links_re = new RegExp( "\\[\\[" + image_re_string );
		var allLinks = this.text.splitWeightedByKeys( '[[', ']]' ).uniq();
		for( var i = 0; i < allLinks.length; ++i ) {
			if( links_re.test( allLinks[i] ) ) {
				var replacement = allLinks[i];
				// just put it at the end?
				replacement = replacement.replace( /\]\]$/, ( /\|/.exec( replacement ) ? ' ' : '|' ) + data + ']]' );
				this.text = this.text.replace( allLinks[i], replacement );
			}
		}
		var gallery_re = new RegExp( "^(\\s*" + image_re_string + '.*?)\\|?(.*?)$', 'mg' );
		var replacement = "$1|$2 " + data;
		this.text = this.text.replace( gallery_re, replacement );
	},

If someon has the will to to a perfect reimplementation of that, please :) _→AzaToth 22:59, 19 July 2007 (UTC)

See my talk page, YET more reports of it breaking page formatting anf image capations... :( Sfan00 IMG 21:40, 26 July 2007 (UTC)

 Resolved _→AzaToth 16:47, 30 July 2007 (UTC)

The feature request Warnings: Whenever a user tries to add a warning to a vandal that is currently blocked, add a box that pops up and notifies the user that the vandal is blocked and asks the user to continue or stop with the warning template was marked wontfix with the note there is no machine-readable way to check if a user is blocked (as I know of at least). I was wondering if this could perhaps be done with Special:Ipblocklist, with a query on the username. I just tried it with both currently and previously blocked users, and if a block isn't currently active it responds with The requested IP address or username is not blocked, while an active block gives the block log text for the current block. Seems like it could be machine readable and integrated into twinklewarn somehow. I'm not familiar enough with the JS implementation of regular expressions to give it a try, though. It might also be an unnecessary drain on the servers, so if implemented it should probably be a configurable setting with the default set to off. --Pekaje 18:40, 30 July 2007 (UTC)

Hi, been using Twinkle to tag images, Would be nice if there was an automated wya to de-tag image instances flagged using TWINKLE. Sfan00 IMG 22:27, 30 July 2007 (UTC)